I did a quick test the other day since someone also requested it and it looked really bad.
First, there is a random null popping up.
Second, thorn mail popups aren't working properly: if the attacker took damage from thorn mail, it wouldn't show up. I imagine this is because the default engine doesn't support anything like this and therefore there was no need to implement it.
And third it just isn't intuitive.
Here, I did 50 damage, and OF that 50 damage I absorbed 10.
These popups make it look like I did 60 damage.
It is trivial to make the popups: simply assign values to the result (eg: result.hp_damage, result.hp_drain, result.mp_damage, result.critical, etc)
def armor_effect_thorn_mail_guard(user, armor, effect)
return if user == self
damage = eval(effect.value1)
user.hp -= damage
user.perform_collapse_effect if user.dead?
user.result.hp_damage = damage # new
@result.effect_results.push("%s takes %s damage!" %[user.name, damage])
@result.success = true
make_damage_popups(user) # new
But it's not working for thorn mail.
Edited by Tsukihime, 17 November 2012 - 06:55 AM.