Issues with Yanfly Aftermath Script Fix for Tsukihime's Learn-And-Replace

[Japhasca 3]

Salutations!
Tsukihime provided a wonderful script that would allow a skill to replace another at level up with very minimal work, designer-side. It can be found here:

There's also a script included that provides compatibility with Yanfly's Victory Aftermath, which can be found here:

https://yanflychannel.wordpress.com/rmvxa/battle-scripts/victory-aftermath/

 

The issue is, when a skill is replaced, it WILL show up in the aftermath level up display, but "New Skill" is missing. If the level up does not have a skill that replaces another, or has a skill of both types, "New Skill" will appear.

I was wondering if anyone could take a look at this and see if there's a fix so that "New Skill" will appear in both situations (honestly, I wouldn't mind it if it always appears at level up, even when nothing new is learned.)

Edited May 10, 2020 by Japhasca
Missing word

[PhoenixSoul 1,404]

Spoiler

(Just be glad those scripts aren't locked behind a paywall...)

Hmmm...I'm not sure; I don't have any experience with Learn and Replace, and then with the Aftermath script, I've done some meddling with some of the displayed stuffs, but not any part that deals with leveling up, so I'm not sure if any of my meddling would be of any aid.

Maybe @roninator2 could be of more aid. If not, mayhaps @Rikifive or @Kayzee.

[roninator2 257]

On 5/10/2020 at 10:59 AM, Japhasca said:

"New Skill" is missing

I have to ask, how did you get Hime's script to work? 

I put the notetag in the actor, the class, the skill - even the map because it says in one part .map! <replace: 26 27 28> or  <replace: 26>

But it NEVER replaced ANY skills.

So I grabbed Fomar's skill replace script and it worked perfectly with the notetag in the skill notebox (makes sense).

THEN I saw your problem. So here is the fix.

class Window_VictoryLevelUp < Window_Base
  def draw_new_skills(actor, temp_actor)
    new_skills = actor.skills - temp_actor.skills
    return if new_skills.empty?
    dw = 172 + 24
    dx = contents.width - dw
    change_color(system_color)
    text = YEA::VICTORY_AFTERMATH::SKILLS_TEXT
    draw_text(dx, 0, dw, line_height, text, 0)
  end
end

 

7 hours ago, PhoenixSoul said:

Maybe @roninator2 could be of more aid

certainly

[Japhasca 3]

Thanks so much! I'll give it a shot :)
In the class the tag goes in the note for the skill itself (where you have them listed by level.)

Didn't have any problems getting them to work except at first I was having the new skill delete it self as well so I was very confused!